Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to update the code with kubernetes 1.18? #4

Open
cf250024 opened this issue May 30, 2021 · 2 comments
Open

Is it possible to update the code with kubernetes 1.18? #4

cf250024 opened this issue May 30, 2021 · 2 comments

Comments

@cf250024
Copy link

I guess the code has been tested with api-server nightly build. Since then, there are changes in api-server. I see some errors when I tried to use 1.21 and then 1.18 as well? I am trying to make change locally while reading through the book. But I doubt it could be running without issues after I make changes.

Is it possible to update the code so that it could be compiled and run with api-server 1.18? This will make sure the issues are on us if it can't be running with our local tests. Thanks.
@mhausenblas
Copy link
Member

SGTM, wanna PR it?

@cf250024
Copy link
Author

Yes, please. (is not this PR #3, correct?) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhausenblas @cf250024