Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an 'add-ons' plugin, which provides heroku style addons. #292

Closed
wants to merge 20 commits into from

Conversation

plietar
Copy link
Contributor

@plietar plietar commented Nov 5, 2013

This is still WIP. I've created the PR so people can comment it.
Add-ons provide access to services (e.g. database) by applications.

It is quite similar to heroku's addons.
Add-ons provide a URL, which is passed to applications through environment variables.
The contents of the url is up to the add-on, but should be described in the add-on's doc.

The description of how to use/create plugins is in the docs folder.

See https://github.com/plietar/dokku-addons for addons.

I have added some tests, but they are part of the dokku-addons repo, and work only in vagrant for now.

TODO

  • Basic commands (add/remove/url)
  • Help message
  • Unprovision automatically all add-ons in pre-delete
  • Manage add-ons enabling/installation (eg creation of service's container)
  • Write add-ons for major services
  • Add some automated testing.
  • Make testing work on travis.
  • Add backup-export/backup-import support. (Needs a small change in the backup PR, I'll make a PR or commit them soon)
  • Start addons container after reboot (Possible integration with dokku ps dokku ps #298, or plain upstart)

Comments/suggestions are welcome.

@progrium
Copy link
Contributor

progrium commented Nov 5, 2013

Wow. This'll take some time to digest/review but it looks amazing.

@plietar
Copy link
Contributor Author

plietar commented Nov 5, 2013

Sure, this is still far from being complete, and would be for a not so soon release.

@progrium progrium mentioned this pull request Nov 5, 2013
@progrium
Copy link
Contributor

progrium commented Nov 5, 2013

This'll be a great headlining feature for 0.3.0

@plietar plietar mentioned this pull request Nov 9, 2013
10 tasks
@plietar
Copy link
Contributor Author

plietar commented Nov 27, 2013

It should be quite stable now, there a few non-essential things left todo.

I've written addons for mariadb, postgresql and redis.
They are on a seperate repo
https://github.com/plietar/dokku-addons

Cloning it and running make install should be enough.

Alternatively, cloning it on the host and running make vagrant will install it into the vagrant box.
The ssh keys need to be setup. (Easiest way is to run dokku's test/run_vagrant)

Add-ons provide access to services (e.g. database) by applications.
This is still WIP.
Add-ons must be enabled before they are used. This allows add-ons to
install dependencies, allocate necessary resources, ...
This is safer and simpler than unprovisioning all apps.
Allow deploying an application in any path, and allow applications to
have a setup script
@enricostano
Copy link

Any news on this?

@Peeja
Copy link

Peeja commented Jan 21, 2014

I'm not using Dokku at the moment, but a few weeks ago I was playing with it using this PR, and things worked well. I'd love to see it land on master.

@sardaukar
Copy link

+1

@AlJohri
Copy link
Contributor

AlJohri commented Mar 6, 2014

+1 this looks amazing

@zachlatta
Copy link

👍

@Kloadut
Copy link
Contributor

Kloadut commented Mar 31, 2014

Looks Awesome To Me

@Zenedith
Copy link

👍

@jnettome
Copy link

Anything new here?

@progrium
Copy link
Contributor

Not yet. Soon...

On Thu, Sep 11, 2014 at 2:46 PM, João Netto [email protected]
wrote:

Anything new here?


Reply to this email directly or view it on GitHub
#292 (comment).

Jeff Lindsay
http://progrium.com

@josegonzalez
Copy link
Member

Small update: This will likely land on 0.4.0.

@AlJohri
Copy link
Contributor

AlJohri commented Nov 15, 2014

that's so exciting! 👍

@sardaukar
Copy link

👍

@josegonzalez
Copy link
Member

Please do not comment unless you are commenting on it being broken or not supporting some case. Helps keep my inbox quiet :)

@josegonzalez
Copy link
Member

Supersceded by #1408. Thanks for the work @plietar. I'm going to come back to this pr and scavenge for the good parts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.