Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: init_if_needed should run checks on constraints even if no init is needed #1096

Merged
merged 20 commits into from
Dec 8, 2021

Conversation

paul-schaaf
Copy link
Contributor

closes #1034

@paul-schaaf paul-schaaf marked this pull request as ready for review December 3, 2021 23:42
lang/src/error.rs Outdated Show resolved Hide resolved
@paul-schaaf
Copy link
Contributor Author

any more comments on this @armaniferrante ?

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@armaniferrante armaniferrante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some nits.

lang/syn/src/codegen/accounts/constraints.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@armaniferrante armaniferrante merged commit 423ddde into coral-xyz:master Dec 8, 2021
AccountNotSigner: 3010,
AccountNotSystemOwned: 3011,
AccountNotInitialized: 3012,
AccountNotProgramData: 3013,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just came across these :) nice 👍

Copy link
Contributor

@jpbogle jpbogle Dec 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always used to search the github repo for the error codes 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lang: init_if_needed does not verify fields if init is not needed
3 participants