InCluster config is used even when KUBECONFIG env is specified

[skmatti]

Expected Behavior

When KUBECONFIG env is specified in the calico-node config, the kubernetes client be created with the specified kubeconfig file.

Current Behavior

There are several places in the calico-node where InClusterConfig is used to create the kubernetes client.

1. calico/node/pkg/lifecycle/startup/startup.go

   Line 132 in 3980e3e

   if config, err := rest.InClusterConfig(); err == nil {

2. calico/node/pkg/lifecycle/startup/startup.go

   Line 332 in 3980e3e

   if config, err = rest.InClusterConfig(); err == nil {

3. calico/node/pkg/cni/token_watch.go

   Line 225 in 3980e3e

   cfg, err := rest.InClusterConfig()

4. calico/node/pkg/lifecycle/shutdown/shutdown.go

   Line 46 in 3980e3e

   if config, err := rest.InClusterConfig(); err == nil {

Possible Solution

Kubernetes client must be created only from KUBECONFIG env if it is specified