Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always sort scopes client-side #583

Merged
merged 1 commit into from
Nov 18, 2022
Merged

fix: always sort scopes client-side #583

merged 1 commit into from
Nov 18, 2022

Conversation

czosel
Copy link
Contributor

@czosel czosel commented Nov 17, 2022

This is important when the ember store already contains data and we can't rely on the sort in the API response.

Based on #584

addon/templates/scopes/edit.hbs Outdated Show resolved Hide resolved
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This is important when the ember store already contains data and we
can't rely on the sort in the API response.
@czosel czosel merged commit d7896ee into main Nov 18, 2022
github-actions bot pushed a commit that referenced this pull request Nov 18, 2022
## [6.2.3](v6.2.2...v6.2.3) (2022-11-18)

### Bug Fixes

* always sort scopes client-side ([#583](#583)) ([d7896ee](d7896ee))
@czosel
Copy link
Contributor Author

czosel commented Nov 18, 2022

🎉 This PR is included in version 6.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants