Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fatal/panic error in internal library #47

Closed
Mzack9999 opened this issue Jan 10, 2023 · 0 comments · Fixed by #49
Closed

Remove fatal/panic error in internal library #47

Mzack9999 opened this issue Jan 10, 2023 · 0 comments · Fixed by #49
Assignees
@Mzack9999
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Milestone
asnmap v1.0.0

Comments

@Mzack9999
Copy link
Member

Description

Multiple internal functions within libs triggers fatal errors with gologger.Fatal(). These errors are all likely recoverable and should be propagated upstream:

Eg.

asnmap/libs/client.go

Line 206 in 5c98487

@Mzack9999 Mzack9999 added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. labels Jan 10, 2023
@Mzack9999 Mzack9999 self-assigned this Jan 12, 2023
@Mzack9999 Mzack9999 mentioned this issue Jan 12, 2023
Merged
@Mzack9999 Mzack9999 linked a pull request Jan 12, 2023 that will close this issue
Logic refactor #49
Merged
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Feb 9, 2023
@ehsandeep ehsandeep added this to the v0.0.2 milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
asnmap v1.0.0
Development

Successfully merging a pull request may close this issue.

Logic refactor projectdiscovery/asnmap
2 participants
@ehsandeep @Mzack9999