Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a global default asn.DefaultClient #138

Closed
Mzack9999 opened this issue Jan 5, 2023 · 0 comments · Fixed by #144
Closed

Create a global default asn.DefaultClient #138

Mzack9999 opened this issue Jan 5, 2023 · 0 comments · Fixed by #144
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@Mzack9999
Copy link
Member

Description

The package asn/asn.go should contain a DefaultClient and global helper functions using this default client. Similarly to net/http and projectdiscovery/gologger:

DefaultClient = New()
...
func GetCIDRsForASNNum(value string) ([]*net.IPNet, error) { ... }
func GetIPAddressesAsStream(value string) (chan string, error) { ... }
@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 5, 2023
@xm1k3 xm1k3 self-assigned this Jan 25, 2023
@xm1k3 xm1k3 linked a pull request Jan 25, 2023 that will close this issue
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Feb 13, 2023
@ehsandeep ehsandeep added this to the mapcidr v1.1.0 milestone Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants