Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in -config flag #323

Closed
badrelmers opened this issue Jul 14, 2023 · 6 comments · Fixed by #341
Closed

bug in -config flag #323

badrelmers opened this issue Jul 14, 2023 · 6 comments · Fixed by #341
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@badrelmers
Copy link

badrelmers commented Jul 14, 2023

Proxify version:

v0.0.9

Current Behavior:

proxify does not respect -config, when I do

proxify.exe -http-addr 127.0.0.1:18080 -config proxify_config

proxify will create cacert.pem and cakey.pem inside proxify_config, but he create config.yaml inside "%USERPROFILE%\.config\proxify"

Expected Behavior:

proxify should create and use config.yaml from proxify_config

Steps To Reproduce:

  1. Run
proxify.exe -http-addr 127.0.0.1:18080 -config proxify_config
  1. See config.yaml in %USERPROFILE%\.config\proxify

all this happen in win 7 64

@badrelmers badrelmers added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jul 14, 2023
@MetzinAround
Copy link

I believe the config file in /.config/proxify is created upon downloading the proxify binary. You might need to delete the original config file before creating a new on in your specified directory.

@ehsandeep can you confirm?

@MetzinAround MetzinAround added the Community ✅ Community team has responded label Jul 16, 2023
@badrelmers
Copy link
Author

badrelmers commented Jul 17, 2023

@MetzinAround thank you for looking into this. I deleted the ~/.config/proxify but it is created again and my custom config is ignored always

@sam5epi0l
Copy link

I gone through the code and I found that it is still in "TODO" list.
Regardless of specified config directory, proxify uses config.yaml from ~/proxify and if it is not present the default config.yaml will be generated in ~/proxify/ directory.

Related files:

@dogancanbakir dogancanbakir self-assigned this Aug 2, 2023
@dogancanbakir dogancanbakir linked a pull request Aug 2, 2023 that will close this issue
4 tasks
@Mzack9999 Mzack9999 removed the Community ✅ Community team has responded label Aug 3, 2023
@leros1337
Copy link

leros1337 commented Aug 10, 2023

make troubles using in docker
[FTL] failed to load open /root/.config/proxify/cakey.pem while saving private key got open /root/.config/proxify/cakey.pem: no such file or directory

upd. issue fixing here #340

@ehsandeep ehsandeep added this to the proxify v0.0.12 milestone Aug 10, 2023
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Aug 12, 2023
@ehsandeep
Copy link
Member

@leros1337 @badrelmers fixed in the latest release.

@komlevv
Copy link

komlevv commented Jan 25, 2024

@ehsandeep
I'm seeing in v0.0.12 that overriding config directory using -config-directory flag with custom path would still create the duplicate folder under $home/.config/proxify/ with a config.yaml file as hardcoded in goflags v0.1.16 https://github.com/projectdiscovery/goflags/blob/821b811e2254cd449cbc353a9a973ef4ff2f8cc1/path.go#L23
Wonder if this is still the case in dev branch and if it is the indended behaviour? Shouldn't there be a single folder for everything config-related?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants