Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RasterLayer to be based on PropertyLayer in Mesa #201

Open
wang-boyu opened this issue Apr 24, 2024 · 1 comment
Open

Refactor RasterLayer to be based on PropertyLayer in Mesa #201

wang-boyu opened this issue Apr 24, 2024 · 1 comment
Labels
enhancement Release notes label help wanted

Comments

@wang-boyu
Copy link
Member

wang-boyu commented Apr 24, 2024 •
edited
Loading

What's the problem this feature will solve?

The current implementation of RasterLayer includes copies of some methods from mesa.space.Grid (see #120), making it difficult to maintain.

Describe the solution you'd like

A more related class in Mesa is its recent PropertyLayer (projectmesa/mesa#1898). RasterLayer could inherit from PropertyLayer with added geospatial capabilities.

Additional context

Might also be beneficial to have part of GeoSpace inherit from _PropertyGrid to manage multiple raster layers.

Some related past issues:
@wang-boyu wang-boyu added enhancement Release notes label help wanted labels Apr 24, 2024
@wang-boyu wang-boyu mentioned this issue Apr 24, 2024
Closed
@EwoutH
Copy link
Member

EwoutH commented Apr 24, 2024

Agree on this! I don't have time to work on it, but I can provide guidance and review.

@wang-boyu wang-boyu mentioned this issue Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Release notes label help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wang-boyu @EwoutH