Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-community/kube-prometheus-stack] manifest_sorter.go:192: info: skipping unknown hook: "crd-install" #155

Closed
NickGraham101 opened this issue Sep 29, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@NickGraham101
Copy link

Describe the bug
Deployment of kube-prometheus-stack fails with error manifest_sorter.go:192: info: skipping unknown hook: "crd-install". The CustomResourceDefinitions are still created

Version of Helm and Kubernetes:

Helm Version: 3.3.1
Kubernetes Version: 1.18.8

Which chart: prometheus-community/kube-prometheus-stack
Which version of the chart: 9.4.4

What happened: Deployment of chart returns an error:

helm.exe upgrade --install --wait --namespace prometheus-stack --version v9.4.4 kube-prometheus-stack prometheus-community/kube-prometheus-stack
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
Release "kube-prometheus-stack" does not exist. Installing it now.
NAME: kube-prometheus-stack
LAST DEPLOYED: Mon Sep 28 16:45:30 2020
NAMESPACE: prometheus-stack
STATUS: deployed
REVISION: 1
NOTES:
kube-prometheus-stack has been installed. Check its status by running:
  kubectl --namespace prometheus-stack get pods -l "release=kube-prometheus-stack"

Though it still seems to install all resources and Prometheus is functional, CRDs are installed:

kubectl get CustomResourceDefinition
NAME                                    CREATED AT
alertmanagers.monitoring.coreos.com     2020-09-28T16:45:27Z
podmonitors.monitoring.coreos.com       2020-09-28T16:45:27Z
prometheuses.monitoring.coreos.com      2020-09-28T16:45:27Z
prometheusrules.monitoring.coreos.com   2020-09-28T16:45:27Z
servicemonitors.monitoring.coreos.com   2020-09-28T16:45:27Z
thanosrulers.monitoring.coreos.com      2020-09-28T16:45:27Z

What you expected to happen: The chart to deploy without returning an error

How to reproduce it (as minimally and precisely as possible):

helm.exe upgrade --install --wait --namespace prometheus-stack --version v9.4.4 kube-prometheus-stack prometheus-community/kube-prometheus-stack
@NickGraham101 NickGraham101 added the bug Something isn't working label Sep 29, 2020
@Kerwood
Copy link

Kerwood commented Sep 29, 2020

Can confirm on:

Helm Version: 3.3.0
Kubernetes Version: 1.18.6

With below command.

helm install prometheus stable/prometheus-operator --namespace prometheus

@NickGraham101
Copy link
Author

I've retried this with version 9.4.9 of the chart but still getting the same issues

@yosefy
Copy link

yosefy commented Oct 8, 2020

confirm

@kkreso
Copy link

kkreso commented Oct 8, 2020

Can confirm on:

Helm Version: 3.3.4
Kubernetes Version: 1.18.8

@scottrigby
Copy link
Member

You can safely ignore this warning. See https://v3.helm.sh/docs/topics/charts_hooks/#the-available-hooks

Note that the crd-install hook has been removed in favor of the crds/ directory in Helm 3.

This hook is still part of the chart because Helm 2 support is not yet finished. After 13 Nov 2020, we can safely remove this hook from the chart. Until then, this is by design.

For more context, see helm/charts#19008

@nickjmv
Copy link

nickjmv commented Mar 24, 2021

We still see this warning, is that normal?

@kubealex
Copy link

In my case, it's not a warning, it's an error

> helm install prom prometheus-community/kube-prometheus-stack -n monitoring
Error: Internal error occurred: failed calling webhook "prometheusrulemutate.monitoring.coreos.com": Post "https://monitoring-kube-prometheus-operator.monitoring.svc:443/admission-prometheusrules/mutate?timeout=10s": service "monitoring-kube-prometheus-operator" not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants