Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constrainLabels allocates too many memory #1276

Closed
khasanovbi opened this issue May 18, 2023 · 2 comments · Fixed by #1296
Closed

constrainLabels allocates too many memory #1276

khasanovbi opened this issue May 18, 2023 · 2 comments · Fixed by #1296
Labels
bug help wanted

Comments

@khasanovbi
Copy link
Contributor

Hi, in my application prometheus allocates a lot of memory in constrainLabels.
I suggest replacing labels inplace instead of creating a new map.
image
@khasanovbi
Copy link
Contributor Author

Related PR #1272

@bwplotka
Copy link
Member

bwplotka commented Jun 7, 2023 •
edited
Loading

Yes, and now I realized it's for very rare feature (new one). Your PR optimizes it well (#1272), but we should likely have a quick path for metrics without constrains. Leaving that open for community to help here 🤗

@Okhoshi Okhoshi mentioned this issue Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not allocate memory when there's no constraints Okhoshi/client_golang
2 participants
@bwplotka @khasanovbi