From 745afa4fc73839c5da259b932cfcedae1406c79f Mon Sep 17 00:00:00 2001
From: Nick Pillitteri <nick.pillitteri@grafana.com>
Date: Fri, 5 Mar 2021 14:56:18 -0500
Subject: [PATCH] Code review feedback

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
---
 model/time.go | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/model/time.go b/model/time.go
index 871e78c7..e684ebd1 100644
--- a/model/time.go
+++ b/model/time.go
@@ -262,13 +262,16 @@ func (d Duration) MarshalJSON() ([]byte, error) {
 
 // UnmarshalJSON implements the json.Unmarshaler interface.
 func (d *Duration) UnmarshalJSON(bytes []byte) error {
-	var err error
 	var s string
 	if err := json.Unmarshal(bytes, &s); err != nil {
 		return err
 	}
-	*d, err = ParseDuration(s)
-	return err
+	dur, err := ParseDuration(s)
+	if err != nil {
+		return err
+	}
+	*d = dur
+	return nil
 }
 
 // MarshalText implements the encoding.TextMarshaler interface.