Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codespell CI job is broken #536

Closed
mwasilew2 opened this issue Jun 15, 2023 · 6 comments · Fixed by #535
Closed

Codespell CI job is broken #536

mwasilew2 opened this issue Jun 15, 2023 · 6 comments · Fixed by #535

Comments

@mwasilew2
Copy link
Contributor

As per: #532 (comment) , there was a new version of codespell pip package released on 14.06.2023 . CI for prometheus/procfs currently fails as a result. TBD if any other prometheus projects are impacted

@mwasilew2
Copy link
Contributor Author

I found the following projects that are using codespell in their CI:

A number of projects in the prometheus-community. Here are a few examples:

I'll focus on testing and fixing projects in prometheus and will see if I get a chance to look into the ones in the prometheus-community

@mwasilew2
Copy link
Contributor Author

+1 on Ben's approach in: #535

@SuperQ
Copy link
Member

SuperQ commented Jun 15, 2023

Yea, I think we used codespell in a few places that have non-go code. But I think we could mostly switch to golangci-lint.

@mwasilew2
Copy link
Contributor Author

@SuperQ if #535 works as expected I'm happy to drive a similar change for node_exporter and mysqld_exporter

@mwasilew2
Copy link
Contributor Author

@SuperQ I was looking at switching node_exporter to golangci-lint misspell and found out that the misspell project has been abandoned for at least 5 years. Do we even want to switch the other projects from codespell to misspell?

@SuperQ
Copy link
Member

SuperQ commented Jun 16, 2023

It looks like golanci is maintaining a fork. They use this fork. Should be fine to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants