Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse Created timestamps from OpenMetrics text format #12980

Closed
ArthurSens opened this issue Oct 14, 2023 · 3 comments
Closed

Parse Created timestamps from OpenMetrics text format #12980

ArthurSens opened this issue Oct 14, 2023 · 3 comments

Comments

@ArthurSens
Copy link
Member

ArthurSens commented Oct 14, 2023 •
edited
Loading

Proposal

In #12936, we added created timestamps to Prometheus proto inspired by the semantics used by OpenMetrics proto; in #12973, we added the ability to parse this same information. Just like OpenMetrics proto, OpenMetrics text already exposes Created Timestamps, but the way Prometheus interprets it is very different from how we wanted it to.

Following our recently accepted proposal (prometheus/proposals#29), we want to change how Prometheus parses created timestamps from OpenMetrics text.

This task is about implementing the CreatedTimestamp() function in openmetricsparse that was added in #12973 following what was proposed.

It should also be implemented behind the feature flag created-timestamp-ingestion
@ArthurSens ArthurSens mentioned this issue Oct 14, 2023
Merged
@bboreham
Copy link
Member

Part of #6541

@ArthurSens ArthurSens mentioned this issue Jan 31, 2024
Closed
@bwplotka bwplotka mentioned this issue Jun 5, 2024
Open
13 tasks
@bwplotka
Copy link
Member

bwplotka commented Aug 14, 2024 •
edited
Loading

Important part was done #14356 - now we just need to add tests and skip CT lines cc @Maniktherana

@bwplotka
Copy link
Member

Fixed in #14356

@Maniktherana Maniktherana mentioned this issue Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse created timestamps from OpenMetrics-Text format ArthurSens/prometheus
3 participants
@bwplotka @bboreham @ArthurSens