Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment for Bitbucket stopped working #346

Open
Mathiou04 opened this issue Jun 12, 2019 · 6 comments
Open

Comment for Bitbucket stopped working #346

Mathiou04 opened this issue Jun 12, 2019 · 6 comments
Labels

Comments

@Mathiou04
Copy link
Contributor

Apparently pronto still uses bitbucket v1.0 API for reading and posting comments. This API has just been removed (it now returns http error code 410).

We need to update to v2.0 API to keep this behaviour.

@starchow
Copy link
Contributor

This bug could be closed after this pull request #352 is merged.

@flaprano
Copy link

flaprano commented Sep 3, 2019

Is there any prediction on when the version with bitbucket API v2 support will be released?

@doomspork
Copy link
Member

The PR has been merged. I would like to get a few others merged in before cutting a new release.

Is it possible for you to point to GH for now?

@flaprano
Copy link

Unfortunately not.
All my projects are stored on Bitbucket.
I totally understand the the wait time for other merges. I will try to make a fork and solo release to use on my projects.
Thanks 😁

@grantmcd
Copy link

@doomspork I pointed the pronto gem to use the master branch and there still appears to be error around comments. Now though it's an error with #parse_comments.

I'm very unfamiliar with the bitbucket api, but I'm wondering if how the responses are parsed needs to get updated as well.

@bradrees
Copy link
Contributor

See this PR, it should fix it #354

I had issues too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants