Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding type hints #16

Open
colinpollock opened this issue Feb 10, 2020 · 1 comment
Open

Adding type hints #16

colinpollock opened this issue Feb 10, 2020 · 1 comment

Comments

@colinpollock
Copy link

First, thanks for making this! I was very happy to be able to drop a dependency on NLTK.

I'm adding type hints to the repo in which I'm using CMUDICT and I'm getting errors from mypy because of missing types.

The guts of this package, cmudict/init.py, is only 83 lines of code. Would you be interested in having type hints? If so, I can submit a pull request.
@davidlday
Copy link
Contributor

Definitely a welcome PR! Let me know if you need anything. This is such a small package, I haven't invested the time in building out guidelines, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colinpollock @davidlday