Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSX gets bytes capped at 3F #5

Open
zambari opened this issue Aug 18, 2017 · 1 comment
Open

OSX gets bytes capped at 3F #5

zambari opened this issue Aug 18, 2017 · 1 comment

Comments

@zambari
Copy link

zambari commented Aug 18, 2017

It took me a while to trace this down, but I was getting incorrect results for some of transmitted values on a mac, namely nothing higher than 0x3F would come through (while the results on windows were correct), I found a list of exceptions in serial.cs, Please consider changing (this is from line 228)

        case RuntimePlatform.WindowsEditor:
	case RuntimePlatform.WindowsPlayer:
	case RuntimePlatform.WindowsWebPlayer:

To following, it fixes the issue on OSX

        case RuntimePlatform.WindowsEditor:
	case RuntimePlatform.WindowsPlayer:
	case RuntimePlatform.WindowsWebPlayer:
	case RuntimePlatform.OSXEditor:
	case RuntimePlatform.OSXPlayer:
@prossel
Copy link
Owner

prossel commented Apr 13, 2018

Thank you @zambari for your feedback. Could you check if v0.4.0 still has the problem ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prossel @zambari