Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building on s390x fails test #12573

Open
2 tasks
adelton opened this issue Apr 10, 2024 · 0 comments · May be fixed by #12574
Open
2 tasks

Building on s390x fails test #12573

adelton opened this issue Apr 10, 2024 · 0 comments · May be fixed by #12574

Comments

@adelton
Copy link

adelton commented Apr 10, 2024

Description of the bug

When building PrusaSlicer on Fedora on s390x, I get test error

3: /builddir/build/BUILD/PrusaSlicer-version_2.7.2/tests/libslic3r/test_point.cpp:36: FAILED:
3:   CHECK( std::abs(line.distance_to(Point{100, 0})) == Approx(0) )
3: with expansion:
3:   0.0 == Approx( 0.0 )

It is very similar to #2461 which since got reimplemented from Perl to C++ but the fix b7f9329 did not seem to make the reimplementation.

Project file & How to reproduce

none

Checklist of files included above

  • Project file
  • Screenshot

Version of PrusaSlicer

2.7.2

Operating system

Fedora rawhide s390x

Printer model

none
adelton pushed a commit to adelton/PrusaSlicer that referenced this issue Apr 10, 2024
On s390x, the distance seems to be a tiny bit off zero.
69a9325 
Fixes prusa3d#12573.
@adelton adelton linked a pull request Apr 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

On s390x, the distance seems to be a tiny bit off zero. adelton/PrusaSlicer
1 participant
@adelton