Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black fails due to _unicodefun #2963

Closed
NAThompson opened this issue Mar 28, 2022 · 3 comments
Closed

black fails due to _unicodefun #2963

NAThompson opened this issue Mar 28, 2022 · 3 comments
Labels
C: packaging Installation and packaging of Black R: duplicate This issue or pull request already exists T: bug Something isn't working

Comments

@NAThompson
Copy link

Describe the bug

On Centos 7:

WARNING: You are using pip version 21.2.3; however, version 22.0.4 is available.
$ python3.9 -m venv venv
$ source venv/bin/activate.csh
(venv) $ python3 -m pip install black
(venv) $ black --version
black, 22.1.0 (compiled: yes) 
(venv) $ black . --check --diff --color
Traceback (most recent call last):
  File "~/venv/bin/black", line 8, in <module>
    sys.exit(patched_main())
  File "src/black/__init__.py", line 1423, in patched_main
  File "src/black/__init__.py", line 1409, in patch_click
ImportError: cannot import name '_unicodefun' from 'click' (~/venv/lib/python3.9/site-packages/click/__init__.py)

Additional context

This just popped up today in CI; it was not observed earlier. Maybe the dependencies are not tightly pinned?

@NAThompson NAThompson added the T: bug Something isn't working label Mar 28, 2022
@laundmo
Copy link
Contributor

laundmo commented Mar 28, 2022

I found a solution: this is a issue with the newest click. if you install click==8.0.4 it should work

@Sillocan
Copy link

Yep. Click 8.1.0 was released with a breaking change.

@JelleZijlstra
Copy link
Collaborator

Going to close in favor of #2964 which is now pinned.

@ichard26 ichard26 added R: duplicate This issue or pull request already exists C: packaging Installation and packaging of Black labels Mar 28, 2022
thejcannon added a commit to pex-tool/pex that referenced this issue Mar 28, 2022
thejcannon added a commit to pex-tool/pex that referenced this issue Mar 28, 2022
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this issue Apr 4, 2022
Looks like the version of Black we were using broke due to a change in click (xref psf/black#2963) - this PR bumps us to the latest version, which resolves those issues (and makes some minor styling changes)

Authors:
  - Charles Blackmon-Luca (https://github.com/charlesbluca)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #889
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this issue Apr 6, 2022
…rect column indexing (#511)

This PR resolves three separate issues caused by changes to our dependencies:
1. The version of Black we were using broke due to a change in click (xref psf/black#2963). This PR bumps us to the latest version, which resolves those issues (and makes some minor styling changes).
2. rapidsa/cudf#10589 changed the `CUDA_TRY` macro to `CUDF_CUDA_TRY` and `CHECK_CUDA` to `CUDF_CHECK_CUDA`, so cuspatial needs to make that change as well.
3. rapids/cudf#10516 removed support for direct indexing of columns via `__getitem__`. This PR replaces those calls with the appropriate methods.

Authors:
  - Charles Blackmon-Luca (https://github.com/charlesbluca)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Paul Taylor (https://github.com/trxcllnt)
  - Mark Harris (https://github.com/harrism)

URL: #511
pajowu added a commit to okfde/froide that referenced this issue Apr 7, 2022
stefanw pushed a commit to okfde/froide that referenced this issue Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: packaging Installation and packaging of Black R: duplicate This issue or pull request already exists T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants