From 613f38f755eb0286fff31b79db328ad806551166 Mon Sep 17 00:00:00 2001
From: Piyush Sharda <psharda@RSAA-43608.local>
Date: Tue, 27 Aug 2024 22:21:30 +0200
Subject: [PATCH] create and call a function in networks to balance charge

---
 networks/metal_chem/actual_network.H        |  4 ++++
 networks/metal_chem/actual_network_data.cpp | 11 ++++++++++-
 unit_test/burn_cell_metal_chem/burn_cell.H  | 16 +++-------------
 3 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/networks/metal_chem/actual_network.H b/networks/metal_chem/actual_network.H
index 1e9513acf..a9329bb76 100644
--- a/networks/metal_chem/actual_network.H
+++ b/networks/metal_chem/actual_network.H
@@ -8,6 +8,7 @@
 
 #include <fundamental_constants.H>
 #include <network_properties.H>
+#include <burn_type.H>
 
 using namespace amrex;
 
@@ -32,4 +33,7 @@ namespace Rates
 
 }
 
+
+void balance_charge(burn_t& state);
+
 #endif
diff --git a/networks/metal_chem/actual_network_data.cpp b/networks/metal_chem/actual_network_data.cpp
index 7c5af518f..e86f1548a 100644
--- a/networks/metal_chem/actual_network_data.cpp
+++ b/networks/metal_chem/actual_network_data.cpp
@@ -1,6 +1,5 @@
 #include <actual_network.H>
 
-
 namespace network
 {
 
@@ -61,4 +60,14 @@ void actual_network_init()
         }
 
     }
+}
+
+void balance_charge(burn_t& state)
+{
+
+    // update the number density of electrons due to charge conservation
+    state.xn[2] = -state.xn[5] - state.xn[9] + state.xn[3] + state.xn[6] + state.xn[8] +
+                  2.0 * state.xn[13] + state.xn[11] + state.xn[14] + state.xn[16] + state.xn[21] +
+                  state.xn[24] + state.xn[26] + state.xn[28] + state.xn[29] + state.xn[31];
+
 }
\ No newline at end of file
diff --git a/unit_test/burn_cell_metal_chem/burn_cell.H b/unit_test/burn_cell_metal_chem/burn_cell.H
index 296467fc3..6adf64545 100644
--- a/unit_test/burn_cell_metal_chem/burn_cell.H
+++ b/unit_test/burn_cell_metal_chem/burn_cell.H
@@ -8,6 +8,7 @@
 #include <eos.H>
 #include <extern_parameters.H>
 #include <network.H>
+#include <actual_network.H>
 
 amrex::Real grav_constant = C::Gconst;
 
@@ -237,9 +238,6 @@ auto burn_cell_c() -> int {
     // scale the density
     dd += dt * (dd / tff);
 
-    //std::cout << "step params " << dd << ", " << tff << ", " << tff_reduc << ", " << rhotmp << ", " << state.xn << std::endl;
-    //std::cout << "old " << dd - dt * (dd / tff) << ", delta " << dt * (dd / tff) << ", new " << dd << std::endl;
-
     // stop the test if dt is very small
     if (dt < 10) {
       break;
@@ -257,9 +255,7 @@ auto burn_cell_c() -> int {
     }
 
     // update the number density of electrons due to charge conservation
-    state.xn[2] = -state.xn[5] - state.xn[9] + state.xn[3] + state.xn[6] + state.xn[8] +
-                  2.0 * state.xn[13] + state.xn[11] + state.xn[14] + state.xn[16] + state.xn[21] +
-                  state.xn[24] + state.xn[26] + state.xn[28] + state.xn[29] + state.xn[31];
+    balance_charge(state);
 
     // input the scaled density in burn state
     rhotmp = 0.0_rt;
@@ -277,8 +273,6 @@ auto burn_cell_c() -> int {
     // do the actual integration
     burner(state, dt);
 
-    //std::cout << "after burn: " << state << std::endl;
-
     // ensure positivity and normalize
     //amrex::Real inmfracs[NumSpec] = {-1.0};
     //amrex::Real insum = 0.0_rt;
@@ -295,11 +289,7 @@ auto burn_cell_c() -> int {
     //}
 
     // update the number density of electrons due to charge conservation
-    state.xn[2] = -state.xn[5] - state.xn[9] + state.xn[3] + state.xn[6] + state.xn[8] +
-                  2.0 * state.xn[13] + state.xn[11] + state.xn[14] + state.xn[16] + state.xn[21] +
-                  state.xn[24] + state.xn[26] + state.xn[28] + state.xn[29] + state.xn[31];
-
-    //std::cout << "conserved elec: " << state.xn[2] << std::endl;
+    balance_charge(state);
 
     // reconserve mass fractions post charge conservation
     //insum = 0;