Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

character sets #15

Open
pshaughn opened this issue Jun 14, 2018 · 1 comment
Open

character sets #15

pshaughn opened this issue Jun 14, 2018 · 1 comment

Comments

@pshaughn
Copy link
Owner

Strings that aren't enumeration constants need to go over the network in these situations:

  • usernames
  • passwords
  • input strings for game frames
  • argument strings for game commands
  • chat messages

Behavior for interesting strings in these cases needs to be well-defined and testable.

current situation:

  • message is parsed from JSON, server hangs up on a client if it can't parse the client's message
  • creating a user requires the username to be ascii alphanumeric
  • input strings and command arguments are generated and used by playset code
  • chat messages are (to be) implemented by taking an input element's value, sending it via JSON, and putting it in an element's textContent, with a filter on its string length as defined by Javascript String.prototype.length. This could raise various issues, but they should all be client-side issues and not require any particular server bulletproofing.
@pshaughn
Copy link
Owner Author

Username case-sensitivity is worth consideration here: if uSER exists, should usER be creatable? (currently yes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant