Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android App won't connect #34

Closed
jkantr opened this issue Apr 22, 2016 · 3 comments
Closed

Android App won't connect #34

jkantr opened this issue Apr 22, 2016 · 3 comments

Comments

@jkantr
Copy link

jkantr commented Apr 22, 2016

Android app complains about "the API version is not the same". I imagine this is because of the new 6.0.0 versioning upstream? Not sure what the work around would be here. I will try to find an archived version of the apk for now.

Edit: Although now that I'm looking.. the android apk hasn't been updated since July 2014, so it isn't that.

@jkantr
Copy link
Author

jkantr commented Apr 22, 2016

Alright, well I see that with some added features the API version was bumped to 1.5 from 1.4

Is this a full breaking incompatibility to the existing android app? Is there an alternative that I'm missing?

@psieg
Copy link
Owner

psieg commented Apr 23, 2016

Hi,

the change is a minor addition (#13), which is why only the minor version was increased (see semver.org). So IMO the best option is to contact the creator of the app to accept 1.X with X >= 4 as API version.

On the other hand this is a fork and we don't know what the Lightpack people are going to do if they change something - they might release a different 1.5 someday. Assuming you're talking about the "Prismatik Controller" app, I tried using it with API version 1.4.1, so that would be another option. This is what was done in PR #27 with the Lightpack firmware, because it happened to work. BUT (a) unpublishing 1.5 is bad (b) it might break existing clients which don't expect another number after the minor version.

@psieg
Copy link
Owner

psieg commented Apr 30, 2016

Fixed in ba68f77. @damianromanowski you might want to adjust your scripts for the next release - check for Prismatik API 2.0

@psieg psieg closed this as completed Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants