Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check logger before closing polyglot logger #10

Conversation

viniciusjusten
Copy link
Contributor

Fixes error when LoggingPolyglot.fatal_error is called before creating a Polyglot log.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.71%. Comparing base (90e3a49) to head (63c7a0c).

❗ Current head 63c7a0c differs from pull request most recent head 0d176f5. Consider uploading reports for the commit 0d176f5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   79.61%   79.71%   +0.09%     
==========================================
  Files           4        4              
  Lines         206      207       +1     
==========================================
+ Hits          164      165       +1     
  Misses         42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guilhermebodin guilhermebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bump the patch in Project.toml. After this we can make a new release

@guilhermebodin guilhermebodin merged commit 7de6df6 into psrenergy:master Mar 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants