Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete buttons and indices slightly off in demo #318

Closed
jywarren opened this issue Aug 6, 2018 · 5 comments
Closed

Delete buttons and indices slightly off in demo #318

jywarren opened this issue Aug 6, 2018 · 5 comments
Assignees
Labels

Comments

@jywarren
Copy link
Member

jywarren commented Aug 6, 2018

I noticed after adding the new colorbar module, the delete buttons delete the wrong module, it deletes the n+1 module instead of n -- probably to do with the extra "parent" meta module?

Another smaller thing is that once the metamodule is expanded, the meta-module's UI controls don't seem to work any more, is that right? Maybe we should hide the meta module UI until we have fully internalized meta modules as in #315?

@tech4GT your thoughts?

@jywarren jywarren added the bug label Aug 6, 2018
@gitmate
Copy link

gitmate bot commented Aug 6, 2018

GitMate.io thinks possibly related issues are #286 (get settings updates in demo to only run() from current index), #223 ((upcoming) Add "post to PublicLab.org" button to embeddable demo), and #278 (Module not found error in demo).

1 similar comment
@gitmate
Copy link

gitmate bot commented Aug 6, 2018

GitMate.io thinks possibly related issues are #286 (get settings updates in demo to only run() from current index), #223 ((upcoming) Add "post to PublicLab.org" button to embeddable demo), and #278 (Module not found error in demo).

@tech4GT
Copy link
Member

tech4GT commented Aug 6, 2018

@jywarren hmm I see!! Let me see what can be done

@jywarren
Copy link
Member Author

jywarren commented Aug 6, 2018

Very nice though!

overlay

@ghost ghost assigned tech4GT Aug 6, 2018
@ghost ghost added the in-progress label Aug 6, 2018
@tech4GT
Copy link
Member

tech4GT commented Aug 28, 2018

This issue has been already solved, now closing this up.

@tech4GT tech4GT closed this as completed Aug 28, 2018
@ghost ghost removed the in-progress label Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants