Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of image sequencer description #390

Closed
5 tasks
aashna27 opened this issue Oct 5, 2018 · 6 comments
Closed
5 tasks

Fix alignment of image sequencer description #390

aashna27 opened this issue Oct 5, 2018 · 6 comments

Comments

@aashna27
Copy link

aashna27 commented Oct 5, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem

Fixing the alignment of image sequencer description found on the home page.

📋 Solution

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the files $index.html and $demo.css in the $examples repository (press the little pen Icon) and edit as shown below.

See this page for some help in taking your first steps!

Below is an explanation to go about the Solution :

  1. Go to line 43 of index.html:
      <p>
  1. And modify it as-
       <p class="description-container">

3.Then go to demo.css in $examples repository and add the following lines at the end of the stylesheet-

p.description-container {
    width: 65%;
    margin: 15px auto;
}
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@gitmate
Copy link

gitmate bot commented Oct 5, 2018

GitMate.io thinks the contributors most likely able to help are @jywarren, and @tech4GT.

Possibly related issues are #173 (Building out a contributor community for Image Sequencer), #23 (Planning Issue for the Image Sequencer GSoC Project), #5 (image cropping module), and #378 (add a website icon to the website link).

1 similar comment
@gitmate
Copy link

gitmate bot commented Oct 5, 2018

GitMate.io thinks the contributors most likely able to help are @jywarren, and @tech4GT.

Possibly related issues are #173 (Building out a contributor community for Image Sequencer), #23 (Planning Issue for the Image Sequencer GSoC Project), #5 (image cropping module), and #378 (add a website icon to the website link).

@Paarmita
Copy link
Member

Paarmita commented Oct 5, 2018

@aashna27 Can u please also provide the misplaced alignment of image sequencer description, in order to understand the problem better?
Thanks!

@aashna27
Copy link
Author

aashna27 commented Oct 5, 2018

Yeah sure @Paarmita
The previous alignment of the description is as follows:
image

The modified look will be :
image

@gowrimanoharir
Copy link

Hi, can I work on this?

@tech4GT
Copy link
Member

tech4GT commented Oct 5, 2018

Hello @aashna27 the description is supposed to take up that width, it's not a bug. Closing this one now. Thanks for your help!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants