Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorbar overlay module with more advanced design #430

Open
jywarren opened this issue Oct 21, 2018 · 9 comments · May be fixed by #1574
Open

Colorbar overlay module with more advanced design #430

jywarren opened this issue Oct 21, 2018 · 9 comments · May be fixed by #1574

Comments

@jywarren
Copy link
Member

After #285, we now can generate and overlay a colobar, and it looks great:

I'm thinking what the next step could be; we could potentially work on text overlay (currently in #165 but will be broken out) to show labels

and also display the colorbar with an outline (we also don't have "drawing rectangles" as a module... but we could! break this out too!)

The goal might be something like this:

colorbar-image-sequencer

We could also have the colorbar not be overlaid on the image, but shown below it. This could be done with the crop module maybe cropping at larger than the current canvas (although I'm not sure this will work -- would it leave white space?) https://github.com/publiclab/image-sequencer/blob/88364decf6a6111a0be31fd98010576d5c6f918e/src/modules/Crop/info.json

This could be broken into 3 different issues to solve.

@gitmate
Copy link

gitmate bot commented Oct 21, 2018

GitMate.io thinks possibly related issues are #285 (Colorbar generation module), #116 (Image overlay module), #108 (Math Module), #112 (Scale module), and #5 (image cropping module).

1 similar comment
@gitmate
Copy link

gitmate bot commented Oct 21, 2018

GitMate.io thinks possibly related issues are #285 (Colorbar generation module), #116 (Image overlay module), #108 (Math Module), #112 (Scale module), and #5 (image cropping module).

@gitmate gitmate bot mentioned this issue Oct 21, 2018
@ho-dor
Copy link

ho-dor commented Nov 2, 2018

can I work on this @jywarren ?

@jywarren
Copy link
Member Author

That would be super - we'd love your help!

@jywarren
Copy link
Member Author

I've added a new issue for setting the background during a crop operation: #467

@jywarren
Copy link
Member Author

So, this sequence is getting closer! https://sequencer.publiclab.org/examples/#steps=crop{x:0|y:0|w:611|h:479},gradient{},colormap{colormap:stretched},crop{x:0|y:0|w:611|h:60},resize{resize:25%25},overlay{x:5|y:5|offset:-4}

But I still can't get it to appear in the newly added padding below the image that results from the crop. But closer!

@Mridul97
Copy link

Mridul97 commented Dec 28, 2018

@tech4GT I would like to work on this issue!

@Mridul97
Copy link

Mridul97 commented Dec 29, 2018

I am thinking to implement drawing rectangles module first, so that we can use it to display the colorbar with an outline!

@rishabhshuklax
Copy link
Member

@jywarren I made something like this

newColorbar

Is this what we require?

@rishabhshuklax rishabhshuklax linked a pull request Jan 25, 2020 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants