Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in example/lib/defaultHtmlStepUi.js #480

Closed
harshkhandeparkar opened this issue Nov 18, 2018 · 8 comments
Closed

Bug in example/lib/defaultHtmlStepUi.js #480

harshkhandeparkar opened this issue Nov 18, 2018 · 8 comments

Comments

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Nov 18, 2018

Flash Message During Step Removal Typo Bug

gci-bug

$('#stepRemovedNotification').DOMNotification.fadeIn(500).delay(200).fadeOut(500);

DOMNotification is not defined and is a typo

@welcome
Copy link

welcome bot commented Nov 18, 2018

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@gitmate
Copy link

gitmate bot commented Nov 18, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #408 (Typo in info.json), #401 (Typo in CONTRIBUTING.MD), and #25 (Issues With ImageManipulation.js).

1 similar comment
@gitmate
Copy link

gitmate bot commented Nov 18, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #408 (Typo in info.json), #401 (Typo in CONTRIBUTING.MD), and #25 (Issues With ImageManipulation.js).

@harshkhandeparkar harshkhandeparkar changed the title Typo in example/lib/defaultHtmlStepUi.js Bug in example/lib/defaultHtmlStepUi.js Nov 19, 2018
@grvsachdeva
Copy link
Member

hey @harshkhandeparkar, could you please give your Email ID?

@harshkhandeparkar
Copy link
Member Author

Why do you need by Email ID?

@grvsachdeva
Copy link
Member

Actually, we can talk here only:

@harshkhandeparkar thanks so much for your enthusiasm in the weekly check-in! Sorry we made some last minute changes, but we thought it over a bit and felt that a) we worried that some memes might end up making people feel bad, even by accident, and b) we have a strong need for reviewers anyways. I hope this makes sense why we deleted your comment from weekly check-in and didn't want this to be discouraging - we are super grateful for your help in collaboratively hosting the community. Thanks so much for your time and keep up the great work!

@harshkhandeparkar
Copy link
Member Author

Oh Np. Even I thought I would delete my comment but you had already done that. I was hesitant to comment at first but I saw your comment and I thought it won't be much of an awkward thing. But anyways, thank you, Np, welcome etc. 😊

@grvsachdeva
Copy link
Member

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants