Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'let' not allowed outside strict mode - error #646

Closed
jywarren opened this issue Jan 10, 2019 · 8 comments
Closed

'let' not allowed outside strict mode - error #646

jywarren opened this issue Jan 10, 2019 · 8 comments

Comments

@jywarren
Copy link
Member

Travis shows an error in the logs, here:

https://travis-ci.org/publiclab/image-sequencer/jobs/477803581#L830-L834

/home/travis/build/publiclab/image-sequencer/src/ImageSequencer.js:135
    let progressObj, index = 0;
    ^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

But it doesn't fail - i'd like to address both issues, getting Travis to actually report a failure in this case, AND then resolving it -- probably with adding strict mode?

@jywarren
Copy link
Member Author

Related to #645

@gitmate
Copy link

gitmate bot commented Jan 10, 2019

GitMate.io thinks possibly related issues are #361 (unreachable code error), #147 (replaceImage() returns error), #537 (Module not found error on demo), #278 (Module not found error in demo), and #145 ("reader is not defined" error on demo).

1 similar comment
@gitmate
Copy link

gitmate bot commented Jan 10, 2019

GitMate.io thinks possibly related issues are #361 (unreachable code error), #147 (replaceImage() returns error), #537 (Module not found error on demo), #278 (Module not found error in demo), and #145 ("reader is not defined" error on demo).

@Divy123
Copy link
Member

Divy123 commented Jan 10, 2019

I would like to work upon it.

@grvsachdeva
Copy link
Member

Go ahead @Divy123!

@Divy123
Copy link
Member

Divy123 commented Jan 15, 2019

@jywarren @tech4GT I tested it by creating a test that uses a simple assignment using 'let' and the test still passed without any errors.
Hence I don't think there is a problem with our image-sequencer code itself.
Also when I went through https://node.green/, it should fail the test.
Would like to know your opinion on this.

@Divy123
Copy link
Member

Divy123 commented Jan 24, 2019

Any opinions @jywarren .Also since the tests for node 4 has been removed, I think we can close this issue.

@harshkhandeparkar
Copy link
Member

No longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants