Cannot see font-awesome icons under login

[sashadev-sky]

in the PR #633 a new <link> tag was added to application.html.erb for font-awesome:

mapknitter/app/views/layouts/application.html.erb

Line 15 in 5f25aa6

<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.8.2/css/all.css" integrity="sha384-oS3vJWv+0UjzBfQzYUhtDYW+Pj2yciDJxpsK1OYPAYjqT085Qq/1cq5FLXAZQ7Ay" crossorigin="anonymous">

This makes it so that the icons no longer show up for this particular set of icons:

Removing this line brings the icons back

@stefannibrasil does this cause the same problem for you locally? Also was this meant for a font-awesome upgrade? I think we should update this dependency across the whole repo if were upgrading, and then link to the relative path in the href. Right now we are pulling 2 versions

[kaustubh-nair]

I believe this should fix it. 75c2fef

[sashadev-sky]

hmm, since it's a small bug, could you maybe submit a quick PR just for that part? @kaustubh-nair. Then we can confirm its fixing it.

[kaustubh-nair]

@sashadev-sky I think it should be fixed now, since a671852 got merged. Can you check again and confirm?

[sashadev-sky]

Yes its fixed! But I still see were pulling 2 different font-awesome packages into /public/lib that are version 4.2.0 and also pulling in another one via cdn that is version 5.8.2. I am going to open a PR to try getting it down to 1? Or is there a reason for this? @kaustubh-nair

One of the packages might go away after I link mapknitter to the latest LDI release where I removed font-awesome as a dependency

[kaustubh-nair]

Hey @sashadev-sky I've tried looking into the cause of this.. I think this is happening because image-sequencer and leaflet-distortableimage have font-awesome as dependencies, which is causing a version mismatch. And maybe we should wait a bit to address this issue, since we are going to switch to yarn soon #702
Thanks!

[sashadev-sky]

@kaustubh-nair also in the process of removing font-awesome dependency in favor of svg sprites so we can use any icons we'd like in LDI! @jywarren

[sashadev-sky]

@kaustubh-nair font awesome has been removed from ldi! Is this issue fixed btw?

[kaustubh-nair]

We're using a new signup popup now right? I think @divyabaid16 implemented it?
Anyway I think the fontawesome issue was solved in Rails 4 upgrade

[sashadev-sky]

@kaustubh-nair yes closing this its stale and resolved!