Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of bug reports/input from Mapping Fellows (Community Atlas) #720

Open
3 of 6 tasks
jywarren opened this issue Jun 18, 2019 · 4 comments · Fixed by #721 or #735
Open
3 of 6 tasks

Collection of bug reports/input from Mapping Fellows (Community Atlas) #720

jywarren opened this issue Jun 18, 2019 · 4 comments · Fixed by #721 or #735

Comments

@jywarren
Copy link
Member

jywarren commented Jun 18, 2019

Our Mapping Fellows (https://publiclab.org/tag/community-atlas) had a call today and we're reporting in a collection of UI/UX input from them here -- very helpful! Thanks Sairam and Mo!

I've separated these out into issues for Leaflet.DistortableImage and MapKnitter. The matching Leaflet.DistortableImage issue is at publiclab/Leaflet.DistortableImage#306

Also cc #312 and #327!

MapKnitter issues

  • replace the chat tab with a link to https://publiclab.org/chat
  • include first image of a map in the "Share on PL" button in the post body field
  • remove "Legacy Editor" link and code
  • Exporting - what is the purpose? Distinguish between "exporting", "sharing", "embedding", Sairam wasn't sure if "exporting" was for some internal purpose
  • we should better distinguish (at least with tooltips) between "deleting" an image and "unplacing it" (where the latter is just taking it off the map, but leaving it in the sidebar. This may be a MapKnitter issue in fact, not LDI) - button in toolbar to unplace an image but not delete it #114

Also aggregating open issues here that will address the updates requested by Mo in https://publiclab.org/notes/molangmuir10/06-10-2019/mapknitter-ui-evaluation?_=1560394957

@divyabaid16
Copy link
Contributor

I will start working with this.
Thanks!

@divyabaid16 divyabaid16 mentioned this issue Jun 19, 2019
5 tasks
@jywarren jywarren reopened this Jun 19, 2019
@divyabaid16
Copy link
Contributor

Hi @jywarren I couldn't understand which button or field you are talking about in the second point.
Can you please elaborate a bit here?
Thanks!

@jywarren
Copy link
Member Author

include first image of a map in the "Share on PL" button in the post body field

I was wondering if we could insert an image into the posts generated by the button here:

image

Here is the code!

<a target="_blank" class="btn btn-outline-secondary" title="Post a research note on Public Lab" href="//publiclab.org/post?title=MapKnitter map of <%= @map.name %>&tags=lat:<%= @map.lat %>,lon:<%= @map.lon %>,mapknitter&body=%3Ciframe%20src=%22https://mapknitter.org/embed/<%= @map.slug %>%22%20style=%22border:none%22%20width=%22100%25%22%20height=%22400px%22%3E%3C/iframe%3E%3Cbr /%3E%3Cbr /%3E<%= @map.description %>%3Cbr /%3Ehttps://mapknitter.org/embed/<%= @map.slug %>" type="button">

@sashadev-sky
Copy link
Member

I think this was an accidental close so reopening!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants