-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated image matching with matcher-core #547
Comments
Exciting!!!!!! Testing at https://rexagod.github.io/Leaflet.DistortableImage/examples/ -- when i press the puzzle piece button: I get:
|
Hey @jywarren! Just to confirm, did you enable the matcher first (from the bottom left button)? |
So, this is all running locally in my browser tab? |
Hm, it seems to hang, with green screen and |
Okay, did you clone it or are you running it from the gh-pages link? |
I just double checked this and the demo link seems to work just fine. Should I record the sequence of steps? |
Also, what about using some of these photos, for a more real-world scenario? I wonder if the flower petals are giving it some trouble? |
This is very cool, @rexagod !!! |
Let's get a good look at the architecture of the code first, but I'm interested in exploring some different UI ideas to see what is most natural for people. Maybe we could open a new issue to discuss UI ideas like:
What takes the most time, generating the points? Thanks! This is so cool! |
Thanks, @jywarren! Briefly responding to the concerns above,
This would actually require the matcher to update the coordinates on every
Okay, this should require a complete refactor of the algorithm from clicks to proximity, maybe we can brainstorm the pros and cons before proceeding with such a big code refactor? What do you think?
Hmm, there are a number of approaches we can take here, I guess. Maybe we can assign it a keybinding, and log that inside the keymapper, or perhaps a separate UI button (similar to current one, but more dynamic)? I'll open up an issue on this.
Yeah, so actually, the loading, or the green spinner splash screen basically is there to compensate for the time taken for the constructor to instantiate the matcher class (which is the main reason for overhead), after which, the actual "matching" is a matter of microseconds, no matter which images you pass to it, since the reference has now been loaded into the cache, which as of now requires the browser to reload in order to access that (ad actually "match" and "stitch" images). So essentially, we can definitely shift to image spinner from screen spinner given that we're good with the browser reloading once the algorithm has been loaded. I'm really excited to see your interest into this, and the future implementations of this module, and just want to brainstorm a bit and be sure about our plans regarding the same before implementing them. Thank you! |
Can we break down the steps the matcher takes, and can we document them in the README? This will really help! I was thinking that we could just redraw the connecting lines in realtime, not recalculate the coordinates. Just redrawing Leaflet lines shouldn't be too expensive!
Hm, shouldn't the event that triggers matching be independent from the algorithm that is triggered? Again, i think documenting how the code is modularized should help us make good decisions here. For example, documenting the lifecycle of the whole interaction would expand on what you've written here and link to specific lines of code:
Does that make sense? Thanks! |
Added docs in publiclab/matcher-core@a1ec607
Sorry, I actually meant the projector and stitcher functions. But let me know if you consider shifting to proximity-based measures, and I'll make it work! Thanks! |
Also, here's the PR comparison: main...rexagod:rexa-soc-ldi |
Actually i was hoping you could break down the |
Shall we move over to that repository to discuss? I've turned it into a PR so there's a place to talk -- #312 -- great! |
Moved over to #312 |
Noting that this got stuck when we needed ES6 and I believe that is now resolved. Thanks all! |
unpinning this to pin the welcome issue, will back pin after |
https://github.com/publiclab/matcher-core/
Discussion thread for
matcher.js
's integration issues intoLeaflet.DistortableImage
./cc @jywarren
The text was updated successfully, but these errors were encountered: