Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new line character to the message displayed on dashboard #4977

Closed
5 tasks
ananyaarun opened this issue Mar 9, 2019 · 8 comments
Closed
5 tasks

Add new line character to the message displayed on dashboard #4977

ananyaarun opened this issue Mar 9, 2019 · 8 comments
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML

Comments

@ananyaarun
Copy link
Member

ananyaarun commented Mar 9, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file _header.html.erb to add a new line in the welcome message displayed on the Dashboard.

Current Behavior
new1old

Expected Behavior
new1final

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

@ananyaarun
Copy link
Member Author

@publiclab/plots2-reviewers Kindly review and label this issue for first timers.

@grvsachdeva grvsachdeva added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML CSS labels Mar 9, 2019
@grvsachdeva
Copy link
Member

@publiclab/community-reps agree with the design?

@madeofhuman
Copy link
Contributor

madeofhuman commented Mar 9, 2019

I'm an Outreachy applicant and I'd love to work on this, @gauravano.

@grvsachdeva
Copy link
Member

Although, we are waiting for a word from @publiclab/community-reps but you can go ahead. Thanks!

@madeofhuman
Copy link
Contributor

@gauravano I ran into a problem when setting up the repo on my system. I followed the instructions up to rake db:setup where I got the error Mysql2::Error: The used table type doesn't support FULLTEXT indexes, which on further tracing, led me to db/schema.rb:58:


add_index "comments", ["comment"], name: "index_comments_on_comment", type: :fulltext if ActiveRecord::Base.connection.adapter_name == 'Mysql2'

I also got a notification to add Mysql2 to my Gemfile.

Now, the problem is that I ran bundle install with --without production mysql flag, and was using the sqlite database config file, so I should not have been getting Mysql errors.

I traced the error further and got to the file config/initializers/abstract_mysql2_adapter.rb. When I commented out the contents of this file and ran rake db:setup again, everything worked fine.

What do you think could be the problem here? Do I create an issue for this?

@grvsachdeva
Copy link
Member

@madeofhuman feel free to open a new issue for this, so that other can also help us in resolving this issue. Also, we are having some discussion about database errors and using a single database, you are welcome to chime there.

Here are the links- #4936, #4919, #4896 .

Thanks!

@madeofhuman
Copy link
Contributor

@gauravano I see you had the same problem in #4936. I added mine (and my solution) as a comment to it. Thanks for pointing that out to me.

@grvsachdeva
Copy link
Member

Thanks, everyone but this issue is not required for now. We'll handle it in re-design project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML
Projects
None yet
Development

No branches or pull requests

3 participants