Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny clean-up of the header on publiclab.org/notes/... content #6361

Closed
5 tasks
ebarry opened this issue Oct 1, 2019 · 1 comment
Closed
5 tasks

Tiny clean-up of the header on publiclab.org/notes/... content #6361

ebarry opened this issue Oct 1, 2019 · 1 comment
Labels
fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet

Comments

@ebarry
Copy link
Member

ebarry commented Oct 1, 2019

Hello! Thank you for considering this request from @joyofsoy !

Please describe the desired behavior.

Viewing at all widths

@joyofsoy suggests that we consider deleting the line: "Read more: publiclab.org/n/#####"
as the short link is already available above. It should not appear no matter what width the browser screen is.

For example, visit https://publiclab.org/notes/Bronwen/09-26-2019/nyc-workshop-saturday-9-28-simple-air-sensors-and-more, which has a short link of https://publiclab.org/n/20999, or see this screenshot:

Screen Shot 2019-09-26 at 2 41 48 PM

  • at all widths, delete the line: "Read more: publiclab.org/n/#####"

Viewing at medium width

As the browser responds to being slightly narrower, we may notice how the date breaks across two lines. This is hard to read, as shown in this screenshot:

Screen Shot 2019-10-01 at 2 08 16 PM

Proposal:

  • at this width, force the entire date to move to a lower line instead of splitting in the middle
  • turn the "link" icon blue to indicate it is a hyperlink.

Viewing at the narrowest width

Below are two screenshots of the narrowest width:

Screen Shot 2019-10-01 at 2 09 54 PM

and with the ... expanded:

Screen Shot 2019-10-01 at 2 12 35 PM

Proposal:

  • remove the duplicate | in the expanded view
  • in both views, turn the "link" icon blue to indicate it is a hyperlink.

Thank you for reading!

@ebarry ebarry added the fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet label Oct 1, 2019
@ebarry
Copy link
Member Author

ebarry commented Oct 1, 2019

This is all covered in #5956

@ebarry ebarry closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet
Projects
None yet
Development

No branches or pull requests

1 participant