Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change function t to translation in layouts/_alerts.html.erb #6727

Closed
5 tasks
Abhinav1299 opened this issue Nov 8, 2019 · 16 comments · Fixed by #7660
Closed
5 tasks

Change function t to translation in layouts/_alerts.html.erb #6727

Abhinav1299 opened this issue Nov 8, 2019 · 16 comments · Fixed by #7660
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@Abhinav1299
Copy link

Abhinav1299 commented Nov 8, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file layouts/_alerts.html.erb in the https://github.com/publiclab/plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is showing where to make changes:

In plots2/app/views/sidebar/_author.html.erb file, change occurrences of function t(...) to translation(...) on line number 26.

<div class="alert alert-warning"><button type="button" class="close" data-dismiss="alert">×</button><i class="fa fa-exclamation-mark"></i><%= t('layout._alerts.request_access') %><a href="/openid/resume"><%= t('layout._alerts.approve_or_deny') %> &raquo;</a></div><% end %><% cache('feature_sitewide-alert', skip_digest: true) do %><%= feature('sitewide-alert') %><% end %></div><script> setTimeout("$('.alerts-container .alert-success').fadeOut('slow')", 7000)</script>

change this to:

<div class="alert alert-warning"><button type="button" class="close" data-dismiss="alert">×</button><i class="fa fa-exclamation-mark"></i><%= translation('layout._alerts.request_access') %><a href="/openid/resume"><%= translation('layout._alerts.approve_or_deny') %> &raquo;</a></div><% end %><% cache('feature_sitewide-alert', skip_digest: true) do %><%= feature('sitewide-alert') %><% end %></div><script> setTimeout("$('.alerts-container .alert-success').fadeOut('slow')", 7000)</script>

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@Abhinav1299 Abhinav1299 added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Nov 8, 2019
@welcome
Copy link

welcome bot commented Nov 8, 2019

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@nstjean
Copy link
Contributor

nstjean commented Nov 8, 2019

Hi @Abhinav1299 ! Thanks so much for opening a FTO, it is much appreciated! You will just have to edit the post to add the information someone will need, such as a link to the file, the repo name (plots2), and where it says DIFF you will add in the line number(s) and show what the code should be after changes.

@Abhinav1299
Copy link
Author

@nstjean I have made the required changes. Thanks for the information.

@nstjean
Copy link
Contributor

nstjean commented Nov 11, 2019

Great thanks!

This issue is open!

@sap143
Copy link
Member

sap143 commented Nov 12, 2019

I want to work on this issue

@nstjean
Copy link
Contributor

nstjean commented Nov 12, 2019

@sap143 Go ahead!

@sap143
Copy link
Member

sap143 commented Nov 13, 2019

I am not able to find line no 26 in plots2/app/views/sidebar/_author.html.erb . It has only 16 lines

@nstjean
Copy link
Contributor

nstjean commented Nov 13, 2019

@sap143 I see there was an error with the file name. It was supposed to be _alerts.html.erb
However it looks like someone created a pull request for this issue already.

@sap143
Copy link
Member

sap143 commented Nov 13, 2019

ok should I leave it now or continue to this issue

@nstjean
Copy link
Contributor

nstjean commented Nov 13, 2019

@sap143 We'll have to find another FTO issue for you! I'll be creating more.

@nstjean
Copy link
Contributor

nstjean commented Jan 17, 2020

This issue is open!

@chirag-wadhwa
Copy link
Contributor

Heya, can I work on this issue...

@nstjean
Copy link
Contributor

nstjean commented Feb 13, 2020

@chirag-wadhwa I just assigned a different issue to you, so we can leave this open for someone else. :)

@Alexjake660
Copy link
Contributor

@nstjean Is this issue still open?

@cesswairimu
Copy link
Collaborator

@Alexjake660 yes t is please go ahead

@Alexjake660
Copy link
Contributor

@cesswairimu check my pull request please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
6 participants