-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighthouse ci for performance and accessibility monitoring #8112
Comments
From #publiclab : My understanding when looking at that link is that they want to start the server locally at their site, not at our server, it can be done, e.g. with docker-compose like we do in our own staging. Following the instructions, it appears a lighthouserc.js needs to exist and have a start command like |
One more concern is that the url option is an array of all urls that can be added to be investigated ... so do we add all the possible urls here in publiclab or how do we dynamically maintain what urls have been changed in a pull request |
Hey @jywarren @icarito @cesswairimu @sagarpreet-chadha should we add this Lighthouse check on every pull request? Thanks ✌️ |
Hey @Tlazypanda , yes it will be very helpful if we get this metric report on each PR/commit. |
However if we donot need historical data, we can easily set this up in few steps, right? Mainly make the lighthousrc.js file, add travil.yml and add github checks. |
Yes @sagarpreet-chadha thanks for the review ✌️ should I move ahead with it then? The temp storage will delete the report in 7 days 😅 |
Hey @Tlazypanda , let's integrate the normal one. |
I am so sorry I missed this. Please forgive! This sounds great and gitpod does make it much easier and cheaper. I agree let's start without history. We can see what is preserved and if we see a use case for preserving once we start to use the feature. I wonder if there's a way to either indicate or simulate that the users table is huge, as that is the source of a lot of slowness. By contrast the nodes table isn't that big. Thanks @Tlazypanda!!!! |
Hey @jywarren @sagarpreet-chadha @icarito Thanks so much for the go-ahead!! ❤️ Actually was navigating through some issues first since right now on gitpod for getting the pr specific url first we need to login with github so in my Gh action script for lighthouse how do I fetch this dynamically generated link available only after login? 😅 The inital link looks like |
Also this should we include all possible urls? 😅 what about the ones that are locked |
Let's start with some of the (public) highest traffic and worst performing ones, as per skylight.io, what do you think? Public routes will have more traffic anyways, and it's an easier starting point. As to your Q about the URL - can you share your script so far? I bet there's a way to find the exact URL after boot in the GitPod docs. But I'm not yet following where you want to use that - can you not hit a Thank you!!! |
Please describe the desired behavior.
Currently, we don't have any ci tool used for performance and accessibility monitoring. Lighthouse ci is google based opensource tool that allows us to check prs for performance and accessibility.
https://github.com/GoogleChrome/lighthouse-ci
https://github.com/GoogleChrome/lighthouse-ci/blob/master/docs/getting-started.md#modifications-for-sites-with-a-custom-server
The text was updated successfully, but these errors were encountered: