Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blog template to show co-authors #8118

Closed
ebarry opened this issue Jul 7, 2020 · 6 comments · Fixed by #8137
Closed

Update blog template to show co-authors #8118

ebarry opened this issue Jul 7, 2020 · 6 comments · Fixed by #8137
Labels
feature explains that the issue is to add a new feature fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet

Comments

@ebarry
Copy link
Member

ebarry commented Jul 7, 2020

Please describe the desired behavior.
@joyofsoy would like to see co-authors displayed on https://publiclab.org/blog. This page has some fancy styling which is nice, and needs a little update to include the newer co-authoring feature on Research Notes.

Additional context (optional)
The original note shows the co-author:
screen_shot_2020-07-06_at_10 05 15_am_480

However, the blog only shows the first author:
screen_shot_2020-07-06_at_10 03 51_am

Thank you!

@ebarry ebarry added the feature explains that the issue is to add a new feature label Jul 7, 2020
@Tlazypanda
Copy link
Collaborator

Hey @ebarry we can probably make an fto out of this as well 😅 if there is no rush ✌️

@ebarry
Copy link
Member Author

ebarry commented Jul 7, 2020

that would be ideal! thanks for reviewing this!

@ebarry ebarry added the fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet label Jul 7, 2020
@mronauli
Copy link
Contributor

mronauli commented Jul 9, 2020

hi @Tlazypanda @ebarry, first timer here! mind if i work on this issue?

@Tlazypanda
Copy link
Collaborator

Hey @mronauli Sure go ahead 🎉 Just adding here that this issue is an fto-candidate and not an fto (first-timers-only issue) so if you are comfortable with working on this go ahead 💯 (in case you face any difficulty with this please feel free to ping ✌️ )

@Tlazypanda
Copy link
Collaborator

Tlazypanda commented Jul 11, 2020

Just adding more information about the files involved here to be edited -

<%=raw translation('tag.blog.by') %> <a href="/profile/<%= node.author.name %>"><%= node.author.name %></a> <%= node.author.new_contributor %>

In this line we need to add coauthors like we have in the notes route file lines 30-34

<% if @node.has_power_tag('with') %>with <% @node.coauthors.each_with_index do |coauthor,i| %>

@mronauli
Copy link
Contributor

Thank you @Tlazypanda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature explains that the issue is to add a new feature fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants