Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option type checking #1728

Open
TimothyGu opened this issue Nov 12, 2014 · 3 comments
Open

Option type checking #1728

TimothyGu opened this issue Nov 12, 2014 · 3 comments

Comments

@TimothyGu
Copy link
Member

As @ForbesLindesay said in #1689, we should probably implement a new error checking system that checks options for type correctness.

@vendethiel
Copy link
Contributor

-1 from me, or at least as an option. I'm not happy with performance butchering again :-).

@ForbesLindesay
Copy link
Member

@vendethiel this would have practically zero impact on performance. It only happens on first build of any given template and we're talking about approximately 6 asserts. Totally negligible.

@TimothyGu thanks for adding an issue to track this.

@vendethiel
Copy link
Contributor

Oooh - You mean API options! Not actual attributes. I read that wayy too fast. Sorry, ignore me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants