Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod images are forced stretching #12

Open
Nelson0491 opened this issue Aug 15, 2024 · 7 comments
Open

Mod images are forced stretching #12

Nelson0491 opened this issue Aug 15, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@Nelson0491
Copy link

For good-looking purpose, many previews of mods are forced to strech. I noticed that there exists different length-width ratio of mod images. Maybe you can add some conditional statements and take different scaling strategies to improve visual effect.

It's easy to find many of them looking not good, too wide, which also reduce the recognition. Below is an example.

image

@pukmajster pukmajster added the enhancement New feature or request label Aug 27, 2024
@pukmajster
Copy link
Owner

This is what i've come up with so far. Any suggestions, @Nelson0491?
image

@Nelson0491
Copy link
Author

Thanks for your work! I think turning the filling space to pure black or the same as the background may be better. By the way I find that your length-width ratio strategy is similiar to 16:9, while the workshop takes 1:1 square appearance. Maybe 16:9 is indeed more suitable for the window. 1:1 is just another choice ( or offerring a UI more similiar to workshop? ) Anyway present is completely acceptable. I just offer another possibility.

屏幕截图 2024-10-18 162138
image

@MerryDreambound
Copy link
Contributor

MerryDreambound commented Oct 18, 2024

Would you be looking for something like this @Nelson0491?
I'm not the main dev but the negative I see with this method, is the seemingly wasted space.

(8 mods total example)
image

@Nelson0491
Copy link
Author

I understand. One solution I come up with is to change to self-adaption width, but that will make the interface not that tidy. Not sure how to balance the space and readability. Because the workshop style also have wasted space, but in vertical direction. However through contrast maybe the workshop one is still a little better. @MerryDreambound

fix

@pukmajster
Copy link
Owner

Here's the blur approach with squares
image

@pukmajster
Copy link
Owner

pukmajster commented Oct 18, 2024

the upcoming v0.4.0 patch already has an "adaptive thumbnail" setting. I can easily modify it so you can choose your preferred aspect ratio, as well has how to fill the wasted space (black, blur or nothing). Sadly it'll never look perfect due to the inconsistency, but I guess having the options is the best we can do, at least for now.

@pukmajster
Copy link
Owner

Update v0.4.0 is out with some new thumbnail settings c: some combinations look bad, but it's a start. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants