From 12662b307ab8d59d11d33d778086c90560d2a0b7 Mon Sep 17 00:00:00 2001 From: confused-Techie Date: Fri, 30 Dec 2022 21:02:10 -0800 Subject: [PATCH 1/5] New Windows Target, new config options --- script/electron-builder.js | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/script/electron-builder.js b/script/electron-builder.js index 4419dfe4a4..b7e3981c0f 100644 --- a/script/electron-builder.js +++ b/script/electron-builder.js @@ -163,8 +163,22 @@ let options = { "icon": icoIcon, "target": [ { "target": "nsis" }, - { "target": "portable" } - ] + { "target": "portable" }, + { "target": "msi" } + ], + "requestedExecutionLevel": "asInvoker", + + }, + // Windows NSIS Configuration + "nsis": { + "perMachine": true, + "oneClick": false, + "allowToChangeInstallationDirectory": true, + "removeDefaultUninstallWelcomePage": true, + "uninstallDisplayName": "Pulsar-Edit Pulsar", + "runAfterFinish": true, + "createDesktopShortcut": true, + "createStartMenuShortcut": true, }, "extraMetadata": { }, From d12d0fe64e2300f71a2db681c3239c9a6f06f8dc Mon Sep 17 00:00:00 2001 From: confused-Techie Date: Fri, 30 Dec 2022 21:31:20 -0800 Subject: [PATCH 2/5] Remove Apparently unsupported config --- script/electron-builder.js | 1 - 1 file changed, 1 deletion(-) diff --git a/script/electron-builder.js b/script/electron-builder.js index b7e3981c0f..7fce7402ba 100644 --- a/script/electron-builder.js +++ b/script/electron-builder.js @@ -174,7 +174,6 @@ let options = { "perMachine": true, "oneClick": false, "allowToChangeInstallationDirectory": true, - "removeDefaultUninstallWelcomePage": true, "uninstallDisplayName": "Pulsar-Edit Pulsar", "runAfterFinish": true, "createDesktopShortcut": true, From 11c7581b3de415b6b862d0cb75ef063b8a2c2bd6 Mon Sep 17 00:00:00 2001 From: confused-Techie Date: Fri, 30 Dec 2022 22:46:36 -0800 Subject: [PATCH 3/5] Seems MSI builds can't have a build number over 65536 --- script/electron-builder.js | 1 - 1 file changed, 1 deletion(-) diff --git a/script/electron-builder.js b/script/electron-builder.js index 7fce7402ba..3759f4bc3b 100644 --- a/script/electron-builder.js +++ b/script/electron-builder.js @@ -164,7 +164,6 @@ let options = { "target": [ { "target": "nsis" }, { "target": "portable" }, - { "target": "msi" } ], "requestedExecutionLevel": "asInvoker", From c7a0fc6d8145568a7337b105c4ea684781e67a0c Mon Sep 17 00:00:00 2001 From: Spiker985 <7829451+Spiker985@users.noreply.github.com> Date: Mon, 2 Jan 2023 21:28:20 -0500 Subject: [PATCH 4/5] Rename uninstall display name --- script/electron-builder.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/script/electron-builder.js b/script/electron-builder.js index 3759f4bc3b..fb3d4d5cdb 100644 --- a/script/electron-builder.js +++ b/script/electron-builder.js @@ -173,7 +173,7 @@ let options = { "perMachine": true, "oneClick": false, "allowToChangeInstallationDirectory": true, - "uninstallDisplayName": "Pulsar-Edit Pulsar", + "uninstallDisplayName": "Pulsar", "runAfterFinish": true, "createDesktopShortcut": true, "createStartMenuShortcut": true, From d71334a9888e27968856398c093f8c4c855f2f9f Mon Sep 17 00:00:00 2001 From: confused-Techie Date: Tue, 3 Jan 2023 12:19:33 -0800 Subject: [PATCH 5/5] @Sertonix recommended changes --- script/electron-builder.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/script/electron-builder.js b/script/electron-builder.js index fb3d4d5cdb..401a3a7001 100644 --- a/script/electron-builder.js +++ b/script/electron-builder.js @@ -165,12 +165,9 @@ let options = { { "target": "nsis" }, { "target": "portable" }, ], - "requestedExecutionLevel": "asInvoker", - }, // Windows NSIS Configuration "nsis": { - "perMachine": true, "oneClick": false, "allowToChangeInstallationDirectory": true, "uninstallDisplayName": "Pulsar",