Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support secrets in config #84

Open
blampe opened this issue Apr 25, 2024 · 0 comments
Open

Support secrets in config #84

blampe opened this issue Apr 25, 2024 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@blampe
Copy link
Contributor

blampe commented Apr 25, 2024

	test := providertest.NewProviderTest(
                ...
		providertest.WithConfig("password", os.Getenv("PASSWORD")),
	)

If "password" is marked as a secret in config, e.g.

config:
  password:
    type: string
    secret: true

the test will fail with

error: validating stack config: Stack 'p-it-bryces-wor-yaml-b7f19499' with configuration key 'password' must be encrypted as it's secret

This is a good thing, since we don't want to accidentally leak any credentials! But we should probably expose a WithSecret option to allow passing encrypted config.

@blampe blampe added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Apr 25, 2024
@mjeffryes mjeffryes removed the needs-triage Needs attention from the triage team label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants