Warn on overlapping configurations with sub resource

[neuni]

Hello!

• Vote on this issue by adding a 👍 reaction
• To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details

EC2 instance defined with following code:

const server = new aws.ec2.Instance("myServer", {
  ami: ubuntu.then(ubuntu => ubuntu.id),
  instanceType: "c5.xlarge",
  tags: {
    Name: "myServer",
  },
  associatePublicIpAddress: false,
  ebsBlockDevices: [
    {
      deleteOnTermination: false,
      deviceName: '/dev/sda1',
      volumeSize: 100,
      volumeType: 'gp3'
    }
  ],
  keyName: myServerKey.keyName,
  monitoring: true,
  vpcSecurityGroupIds: [
    securityGroup.id
  ],
  userData: '',
  subnetId: privateSubnetA.id
}, {
  dependsOn: [
    launchTemplate,
    securityGroup,
    myServerKey
  ]
});

Instance get replaced on every pulumi up because of diff:
+- └─ aws:ec2:Instance myServer replace [diff: ~ebsBlockDevices]

Details:

  ~ ebsBlockDevices: [
      ~ [0]: {
              + deleteOnTermination: false
              ~ deviceName         : "/dev/sda1" => "/dev/sda1"
              + volumeSize         : 100
              + volumeType         : "gp3"
            }
    ]

Steps to reproduce

1. Create EC2 instance and define EBS block device
2. run pulumi up several times

Expected: Instance is not replaced because deviceName did not change
Actual: Instance gets replaced every time

[neuni]

Seems like it's caused by defining "ebsBlockDevices" in "aws.ec2.Instance", but also defining it in the used LaunchTemplate.
After removing the definition from the Instance, it works as expected.
Same issue with Route Tables and Routes:
Adding "routes:[]" to a RouteTable and defining the Routes separately, causes changes on every "pulumi reload" / "pulumi up".

Imho it should raise a warning if I define sub-resources using an array in the higher level resource and defining sub-resources separately at the same time.