aws.rds.Instance finalSnapshotIdentifier attribute should be required when skipFinalSnapshot is not given.

[lech-r]

What happened?

One of the recent pulumi/aws updates (somewhere between 4.0.0 and 5.18.0) has reversed the skip_final_snapshot implicit default. It is now false if not defined explicitly. At the same time, finalSnapshotIdentifier is not a required input for aws.rds.Instance resource.
You are setting people up for trouble with this. Creating aws.rds.Instance resource with minimum required inputs results in skipFinalSnapshot: false and empty finalSnapshotIdentifier attribute. Try to destroy or replace such DB, and Pulumi barks final_snapshot_identifier is required when skip_final_snapshot is false. Fair enough, except it should be required at DB creation time, and is not.

Steps to reproduce

Create aws.rds.Instance resource with minimum required inputs - do not provide skipFinalSnapshot or finalSnapshotIdentifier inputs. Then, pulumi destroy, or make any change that triggers instance replacement.

Expected Behavior

finalSnapshotIdentifier attribute should be required at DB creation time if skipFinalSnapshot is not given.

Actual Behavior

Creating aws.rds.Instance resource with minimum required inputs results in skipFinalSnapshot: false and empty finalSnapshotIdentifier attribute. Destruction then fails with final_snapshot_identifier is required when skip_final_snapshot is false error.

Output of pulumi about

CLI
Version 3.44.0
Go Version go1.19.2
Go Compiler gc

Plugins
NAME VERSION
aws 5.18.0
aws 4.37.5
docker 3.1.0
docker 3.1.0
nodejs unknown
postgresql 3.3.0

Host
OS ubuntu
Version 20.04
Arch x86_64

This project is written in nodejs: executable='/snap/bin/node' version='v16.18.0

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[viveklak]

Thanks for opening the issue. I am afraid this behavior is inherited from the terraform provider: hashicorp/terraform-provider-aws#4910.