Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable aws quicksight template.definition property #2525

Open
danielrbradley opened this issue May 15, 2023 · 1 comment
Open

Re-enable aws quicksight template.definition property #2525

danielrbradley opened this issue May 15, 2023 · 1 comment
Labels
blocked The issue cannot be resolved without 3rd party action. impact/accessibility Something that is difficult or impossible for some people to use kind/enhancement Improvements or new features

Comments

@danielrbradley
Copy link
Member

When introduced it created type names which were too long for the dotnet SDK to render.

Excluded when introduced:

Blocked by:
@danielrbradley danielrbradley added kind/enhancement Improvements or new features blocked The issue cannot be resolved without 3rd party action. impact/accessibility Something that is difficult or impossible for some people to use labels May 15, 2023
@t0yv0
Copy link
Member

t0yv0 commented Jun 30, 2023

In addition to this noting that re-enabling quick sight will cause a lot of similar-looking types being generated increasing the SDK sizes dramatically even if the type names are shorter. Some compression scheme similar to replaceWafV2TypesWithRecursive but perhaps simpler because these types do not have refs to imitate recursion would need to be applied to not take that hit.

@mikhailshilkov mikhailshilkov changed the title Re-enable aws quicksight templates resource Re-enable aws quicksight template.definition property May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked The issue cannot be resolved without 3rd party action. impact/accessibility Something that is difficult or impossible for some people to use kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t0yv0 @danielrbradley