Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ECR getCredentials function out of patches #4678

Open
flostadler opened this issue Oct 29, 2024 · 0 comments
Open

Move ECR getCredentials function out of patches #4678

flostadler opened this issue Oct 29, 2024 · 0 comments
Labels
area/docs Improvements or additions to documentation kind/engineering Work that is not visible to an external user

Comments

@flostadler
Copy link
Contributor

The ECR getCredentials function is currently implemented as an upstream patch (https://github.com/pulumi/pulumi-aws/blob/5af66ab23d9fa7e47f10b384e57e896f2fe0568d/patches/0009-Add-ECR-credentials_data_source.patch). This makes it more complex to maintain and document.
To simplify this, we should move that function to the top level of the provider and maintain it as a native pulumi function that gets mixed in via the muxer.

At the same time we should add documentation and examples for that function.
@flostadler flostadler added area/docs Improvements or additions to documentation kind/engineering Work that is not visible to an external user labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docs Improvements or additions to documentation kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flostadler