Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ECS Fargate Windows containers #720

Closed
nivinjoseph opened this issue Dec 4, 2021 · 4 comments
Closed

Support for ECS Fargate Windows containers #720

nivinjoseph opened this issue Dec 4, 2021 · 4 comments
Labels
help-wanted We'd love your contributions on this issue kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@nivinjoseph
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

AWS recently introduced support for ECS Fargate windows containers.

https://aws.amazon.com/about-aws/whats-new/2021/10/aws-fargate-amazon-ecs-windows-containers/

Currently when using the awsx.ecs.FargateService and awsx.ecs.FargateTaskDefinition classes, Pulumi creates a linux cluster even if "os": "windows" is specified. I suppose this is because Fargate used to be linux only. However this is no longer the case. This could even be considered a bug at this point.

Please advise.

Affected area/feature

awsx.ecs

@nivinjoseph nivinjoseph added the kind/enhancement Improvements or new features label Dec 4, 2021
@mikhailshilkov mikhailshilkov added the help-wanted We'd love your contributions on this issue label Dec 7, 2021
@mikhailshilkov
Copy link
Member

@nivinjoseph Thank you for finding this out! If you could open a PR to fix this issue, that would be greatly appreciated!

@nivinjoseph
Copy link
Author

For starters, the underlying terraform provider needs to support this. I believe this might have been added recently based on the following issue and merged PR.

hashicorp/terraform-provider-aws#21706
hashicorp/terraform-provider-aws#22016

Once the provider is upgraded, then we need to add support for this potentially in the pulumi.aws.ecs module first before exposing it in the pulumi.awsx.ecs since the later uses the former under the hood.

@dustinbrooks
Copy link

Providers have been updated, would like to take advantage of this.

@danielrbradley danielrbradley added the resolution/fixed This issue was fixed label May 16, 2022
@danielrbradley
Copy link
Member

This should now be available in the 1.0.0-beta releases. All underlying provider properties should now be available on the component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted We'd love your contributions on this issue kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants