Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub App does not show preview results in Pulumi Bot comment when running on self-hosted runner in K8s #457

Open
videmsky opened this issue Sep 26, 2024 · 0 comments
Labels
customer/feedback Feedback from customers kind/bug Some behavior is incorrect or out of spec
Milestone

Comments

@videmsky
Copy link

When executing pulumi preview in the context of a PR, the "rich" preview output is not displayed when job is run on a self-hosted runner deployed in k8s via the Actions Runner Controller installed via Helm.

https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/deploying-runner-scale-sets-with-actions-runner-controller

Expected behavior

Image

Current behavior

Preview is correct when viewed in GH Actions job output, but preview is not displayed as a PR comment.

Steps to reproduce

When running a pulumi preview in the context of a PR, I get "rich" preview output when running:
(1) gh hosted runner with ubuntu-latest
(2) self-hosted gh runner on my ARM64 mac

I do not get a "rich" preview when running:
(3) self-hosted gh runner installed with Helm on K8s. (local Kind cluster)

Even in the same PR, I can get the "rich" preview to show with a trivial commit and switching between (1) & (2). Another commit but targeting (3) does not generate the preview.

videmsky/aws-ts-static-website#2

Context (Environment)

Pulumi Preview as a comment is helpful during PR code reviews.

Affected feature

Github App

@videmsky videmsky added customer/feedback Feedback from customers needs-triage Needs attention from the triage team labels Sep 26, 2024
@cleverguy25 cleverguy25 removed the needs-triage Needs attention from the triage team label Sep 26, 2024
@cleverguy25 cleverguy25 added this to the 0.112 milestone Sep 26, 2024
@mikhailshilkov mikhailshilkov added the kind/bug Some behavior is incorrect or out of spec label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer/feedback Feedback from customers kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

3 participants