Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new filed option in the Pages resource #302

Open
cpanato opened this issue Feb 16, 2023 · 1 comment
Open

add new filed option in the Pages resource #302

cpanato opened this issue Feb 16, 2023 · 1 comment
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/enhancement Improvements or new features

Comments

@cpanato
Copy link

cpanato commented Feb 16, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Github added a new field in the Pages resource called build_type, which now can be legacy or workflow. See https://docs.github.com/en/rest/pages?apiVersion=2022-11-28#create-a-github-pages-site

and that allow selecting the

Screenshot 2023-02-16 at 10 20 01
Screenshot 2023-02-16 at 10 20 10

today pulumi github provider only allow to use the legacy one, will be good to have the option to set this config.

thanks in advance

Affected area/feature

@cpanato cpanato added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Feb 16, 2023
@t0yv0
Copy link
Member

t0yv0 commented Feb 16, 2023

I believe this is not supported yet in the upstream provider https://github.com/integrations/terraform-provider-github/blob/main/github/resource_github_repository.go#L240

Once upstream supports this we will be able to update and support in Pulumi as well.

@t0yv0 t0yv0 added awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/enhancement Improvements or new features and removed needs-triage Needs attention from the triage team kind/enhancement Improvements or new features labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants