Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RepositoryEnvironment does not support prevent_self_review #557

Closed
jku opened this issue Feb 5, 2024 · 2 comments
Closed

RepositoryEnvironment does not support prevent_self_review #557

jku opened this issue Feb 5, 2024 · 2 comments
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/enhancement Improvements or new features

Comments

@jku
Copy link

jku commented Feb 5, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

GitHub deployment environments support the boolean argument prevent_self_review, see GitHub docs on environments

Pulumi does not expose this argument: https://www.pulumi.com/registry/packages/github/api-docs/repositoryenvironment/

Affected area/feature

This is very likely a minor change in the github provider only.
@jku jku added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Feb 5, 2024
@t0yv0
Copy link
Member

t0yv0 commented Feb 6, 2024

Thank you for reporting this @jku

Pulumi provider is tracking the upstream provider for this feature.

prevent_self_review is available in 6.x.x RC:

https://github.com/integrations/terraform-provider-github/blob/v6.0.0-rc1/github/resource_github_repository_environment.go#L42

But it is not available in 5.45.0 version this provider is currently tracking. It will become available once upstream releases 6.x and pulumi-github catches up. Thank you for your patience.

@t0yv0 t0yv0 added awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). and removed needs-triage Needs attention from the triage team labels Feb 6, 2024
@jku
Copy link
Author

jku commented Mar 8, 2024

fixed now,thanks

@jku jku closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jku @t0yv0