Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support binary data in github.RepositoryFile #560

Open
kirgene opened this issue Feb 9, 2024 · 1 comment
Open

Support binary data in github.RepositoryFile #560

kirgene opened this issue Feb 9, 2024 · 1 comment
Labels
kind/enhancement Improvements or new features

Comments

@kirgene
Copy link

kirgene commented Feb 9, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently github.RepositoryFile doesn't support binary data in content field.
It would be great if the content field could accept bytes instead of str.
Or have an extra field encoding that can accept "base64", so that content can still be str

Affected area/feature

@kirgene kirgene added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Feb 9, 2024
@t0yv0 t0yv0 removed the needs-triage Needs attention from the triage team label Feb 9, 2024
@t0yv0
Copy link
Member

t0yv0 commented Feb 9, 2024

That sounds like a great suggestion, thank you for filing it! Pulumi also has assets and archives, perhaps this could be handy here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants