Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH]: BranchProtection State Migration #595

Open
iwahbe opened this issue Mar 6, 2024 · 3 comments
Open

[PATCH]: BranchProtection State Migration #595

iwahbe opened this issue Mar 6, 2024 · 3 comments
Labels
area/patch An issue describing an existing patch on upstream and the criteria to close it. kind/engineering Work that is not visible to an external user

Comments

@iwahbe
Copy link
Member

iwahbe commented Mar 6, 2024

Issue describing the patch introduced in #594.

The patch covers from lossy deserialization of old state (pulumi/pulumi-terraform-bridge#1667).

It is under test via TestRepros/586 and can be safely removed when TestRepros/586 doesn't panic without the patch.

@iwahbe iwahbe self-assigned this Mar 6, 2024
@iwahbe iwahbe changed the title [PATCH]: [PATCH]: BranchProtection State Migration Mar 6, 2024
@iwahbe iwahbe removed their assignment Mar 6, 2024
@iwahbe iwahbe added area/patch An issue describing an existing patch on upstream and the criteria to close it. kind/engineering Work that is not visible to an external user labels Mar 6, 2024
@SharpEdgeMarshall
Copy link

Looks like the state migration is still broken:
pulumi-github 6.2.0

+-github:index/branchProtection:BranchProtection: (replace)
            [id=<ID>]
            [urn=<RESOURCE-URN>]
            [provider=<PROVIDER_URN>]
          ~ allowsDeletions              : false => false
          ~ allowsForcePushes            : false => false
          ~ enforceAdmins                : false => false
          ~ lockBranch                   : false => false
          ~ pattern                      : "master" => "master"
          ~ repositoryId                 : "<REPO-ID>" => "<REPO-ID>"
          ~ requireConversationResolution: false => false
          ~ requireSignedCommits         : false => false
          ~ requiredLinearHistory        : false => false
          + restrictPushes               : [
          +     [0]: {
                  + blocksCreations: true
                }
            ]

@ringods
Copy link
Member

ringods commented Jun 12, 2024

@iwahbe We encounter this strange state migration in Pulumiverse too after upgrading from v5 to v6:

Screenshot 2024-06-12 at 11 51 38

@iwahbe
Copy link
Member Author

iwahbe commented Jun 12, 2024

Hmm. Can you file a new issue with a repro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/patch An issue describing an existing patch on upstream and the criteria to close it. kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

3 participants